AppStats: Connection Duration Addition to API #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexadhy
changed the title
|
@Senyoret1 can you also try this? |
mrpalide
approved these changes
Oct 5, 2021
|
I did not check the code, but the functionality appears to be working well. Is the time in seconds? |
it is, is it ok ? |
|
Yes, seconds is ok for me |
|
Everything looks good. I just had one suggestion. We should send [
{
"is_alive":true,
"latency":57,
"upload_speed":2283,
"download_speed":411,
"bandwidth_sent":215672,
"bandwidth_received":235619,
"error":""
}
] |
|
@ersonp done |
ersonp
approved these changes
Oct 8, 2021
jdknives
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? yesFixes #895
Changes:
TODO:
How to test this PR:
vpn-clientapp from the visor via UI / cli